Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] feat: content routing section #291

Closed
wants to merge 1 commit into from

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Jan 15, 2023

Context

To-Do

  • Re-check content
  • Update links to relative path

Latest preview

Please view the latest Fleek preview here.

@salmad3 salmad3 marked this pull request as draft January 15, 2023 17:06
@salmad3 salmad3 marked this pull request as ready for review January 17, 2023 10:39
@salmad3 salmad3 added ready for review PR is ready for review Epic DNM do not merge labels Jan 17, 2023
@salmad3 salmad3 requested a review from p-shahi January 25, 2023 13:57
@salmad3
Copy link
Member Author

salmad3 commented Jan 26, 2023

Link fixes and potential conflicts will be addressed in this PR once all associated material has been added.

@salmad3 salmad3 added the P1 High label Jan 26, 2023
@p-shahi
Copy link
Member

p-shahi commented Feb 2, 2023

Is it better practice and more explicit to convert this PR and any other labeled DNM as a draft pr?

@salmad3
Copy link
Member Author

salmad3 commented Feb 2, 2023

@p-shahi yes, that makes sense - the idea in not making these "epic" PRs as drafts was to identify that the scope and structure changes aren't being drafted but ready for review, and the associated content have their own PRs.

@salmad3 salmad3 marked this pull request as draft February 2, 2023 20:16
@salmad3 salmad3 removed the DNM do not merge label Feb 2, 2023
@p-shahi p-shahi changed the title feat: content routing section [do not merge] feat: content routing section Feb 23, 2023
@p-shahi p-shahi closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic P1 High ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Content Routing section
2 participants